[Webkit-unassigned] [Bug 102689] [WinCairo] Crash when requesting favicon.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=102689





--- Comment #6 from Brent Fulgham <bfulgham at webkit.org>  2012-11-23 21:31:07 PST ---
(From update of attachment 175822)
View in context: https://bugs.webkit.org/attachment.cgi?id=175822&action=review

> Source/WebCore/platform/graphics/win/ImageCairoWin.cpp:98
> +        if (!frameAtIndex(i))

Is it expected that a frame might be null? Maybe we have an underlying problem in frame handling that is allowing null images to pass through.

> Source/WebKit2/win/WebKit2CFLite.def:322
>          ?setTracksRepaints at FrameView@WebCore@@QAEX_N at Z

I'm surprised this is needed; And if it's needed for WebKit2CFLite.def, we should have a similar set of requirements (and tests) on the WebKit2.def side.

> Tools/TestWebKitAPI/win/TestWebKitAPI.vcproj:430
> +						RelativePath="..\Tests\WebCore\win\BitmapImage.cpp"

This will build for WinCairo and regular Windows.  I think this is good, but don't you need to expose the symbols added for WebKit2CFLite.def for our WebKit2.def as well?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.