[Webkit-unassigned] [Bug 102827] [CMake] Optimize binary size by removing dead sections on unix/gcc

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=102827





--- Comment #5 from Laszlo Gombos <laszlo.gombos at webkit.org>  2012-11-23 12:24:10 PST ---
(In reply to comment #2)
> (From update of attachment 175257 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=175257&action=review

> > +    SET(CMAKE_CXX_FLAGS "-ffunction-sections -fdata-sections ${CMAKE_CXX_FLAGS}")
> 
> Usually this is written as SET(VAR "${VAR} additonalStuff")

Patrick, I think the order actually matters and variables that can be tweaked by the user as well should be prepended by the build system and not appended, see also bug 103101. 

You have a point that the patch was not consistent as the compiler flags were prepended but the linker flags were appended - I will change the linker flags so that they are prepended as well.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.