[Webkit-unassigned] [Bug 103006] [EFL][WK2] Missing the routine to check the validation for workqueue

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=103006





--- Comment #28 from Christophe Dumez <christophe.dumez at intel.com>  2012-11-23 03:45:18 PST ---
(From update of attachment 175761)
View in context: https://bugs.webkit.org/attachment.cgi?id=175761&action=review

>>>>> Source/WebKit2/Platform/efl/WorkQueueEfl.cpp:85
>>>>> +        for (size_t i = 0; i < workItemQueue.size(); ++i) {
>>>> 
>>>> Please cache workItemQueue.size() before the loop.
>>> 
>>> Could you explain why it is required?
>> 
>> This is WebKit coding style and this makes sure that the queue size is not retrieved (possibly computed) for every iteration of the loop.
> 
> Is it WebKit coding style? There are so many uses like the style in WebKit.