[Webkit-unassigned] [Bug 103006] [EFL][WK2] Missing the routine to check the validation for workqueue
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Nov 23 03:15:02 PST 2012
https://bugs.webkit.org/show_bug.cgi?id=103006
--- Comment #25 from Jongseok Yang <js45.yang at samsung.com> 2012-11-23 03:17:06 PST ---
(From update of attachment 175761)
View in context: https://bugs.webkit.org/attachment.cgi?id=175761&action=review
>> Source/WebKit2/Platform/efl/WorkQueueEfl.cpp:85
>> + for (size_t i = 0; i < workItemQueue.size(); ++i) {
>
> Please cache workItemQueue.size() before the loop.
Could you explain why it is required?
>> Source/WebKit2/Platform/efl/WorkQueueEfl.cpp:86
>> + Function<void()> function = workItemQueue[i];
>
> Why this useless variable?
I hope that this code meets check-webkit-style.
>> Source/WebKit2/Platform/efl/WorkQueueEfl.cpp:176
>> + MutexLocker locker(m_isValidMutex);
>
> Scope? I don't think we wan to keep the mutex locked for timerWorkItems[i]->dispatch() call
Ok, I fixed that.
>> Source/WebKit2/Platform/efl/WorkQueueEfl.cpp:-179
>> - workQueue->performTimerWork();
>
> Why is this removed?
This function need not be called when m_isValid is false.
So, I inserted this function into performWork().
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list