[Webkit-unassigned] [Bug 101479] [sh4] JavaScriptCore JIT build is broken for sh4 arch

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=101479


Filip Pizlo <fpizlo at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #175743|review?, commit-queue?      |review+, commit-queue-
               Flag|                            |




--- Comment #4 from Filip Pizlo <fpizlo at apple.com>  2012-11-23 02:57:44 PST ---
(From update of attachment 175743)
View in context: https://bugs.webkit.org/attachment.cgi?id=175743&action=review

>> Source/JavaScriptCore/assembler/SH4Assembler.h:2097
>> +    static void printInstr(uint16_t opc, unsigned int size, bool isdoubleInst = true) { };
> 
> Omit int when using unsigned  [runtime/unsigned] [1]

The style queue is right.  Can you fix this style bug and submit for cq? (or commit if you have the privileges).  R=me other than the style.

>> Source/JavaScriptCore/assembler/SH4Assembler.h:2098
>> +    static void printBlockInstr(uint16_t* first, unsigned int offset, int nbInstr) { };
> 
> Omit int when using unsigned  [runtime/unsigned] [1]

Ditto.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.