[Webkit-unassigned] [Bug 103040] Web Inspector: Can we provide an interface to update the "Metrics" and "Highlight Overlay" according to the change of inspected page.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=103040





--- Comment #16 from Alexander Pavlov (apavlov) <apavlov at chromium.org>  2012-11-23 02:56:56 PST ---
(In reply to comment #15)
> (In reply to comment #13)
> > > For example, when mobile is rotated, the width of <div> becomes more wide, but the "Metrics" and "highlight overlay" still show the old results (refer to the attached picture2 and picture3).
> > 
> > I am sure layout takes place and layout updates the overlay. You probably use an old version of build?
> > 
> You mean Chrome, Chrome isn't the newest version. But my port is based on the new version.
> 
> The overlay will be repainted on screen, but with the old size. I set a breakpoint on InspectorOverlay::update, nothing to invoke it when rotated.

A device rotation should inevitably call FrameView::layout(), which invokes InspectorInstrumentation::didLayout(cookie, root), which ultimately calls InspectorOverlay::update(). Did you attach to the right (inspected page) process?

InspectorOverlay::update() always uses the up-to-date node metrics:

drawNodeHighlight()
  -> buildNodeHighlight()
    -> contentBox = renderBox->contentBoxRect();

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.