[Webkit-unassigned] [Bug 103040] Web Inspector: Can we provide an interface to update the "Metrics" and "Highlight Overlay" according to the change of inspected page.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=103040





--- Comment #4 from Pavel Feldman <pfeldman at chromium.org>  2012-11-22 12:11:26 PST ---
(From update of attachment 175628)
View in context: https://bugs.webkit.org/attachment.cgi?id=175628&action=review

Pretty much every line here is wrong. Could you please start with explaining what is not working for you? Please use remote debugging scenario as an example. It is important for us to understand what you expect vs what actually happens. If it is not highlighted in the bug, we should close it as invalid.

The signal you are trying to issue is essentially a "total update". I don't think you are willing to totally update everything upon "change of the inspected page" you did not describe.

> Source/WebCore/inspector/InspectorController.h:102
> +    void documentUpdated();

InspectorController is an interface inspector exposes to the WebKit. Only control commands from WebKit are allowed to go through it, not this one.

> Source/WebCore/inspector/InspectorDOMAgent.cpp:1394
> +    m_frontend->documentUpdated();

You can't just send documentUpdated to the front-end without discarding agent state first.

>> Source/WebCore/inspector/InspectorDOMAgent.h:159
>> +    void documentUpated();
> 
> Typo: should be "documentUpdated"

InspectorDOMAgent is the only one to know when to issue documentUpdated. You can't tell it when to do it from outside. InspectorDOMAgent knows when document instance is updated based on the signals from the WebCore instrumentation (InspectorInstrumentation::)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.