[Webkit-unassigned] [Bug 94987] Add systemTime to DOM events

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=94987





--- Comment #86 from Robert Flack <flackr at chromium.org>  2012-11-22 11:59:21 PST ---
(In reply to comment #81)
> (From update of attachment 174465 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=174465&action=review
> 
> > Source/WebCore/dom/Node.cpp:2601
> > +    return EventDispatcher::dispatchEvent(this, KeyboardEventDispatchMediator::create(KeyboardEvent::create(event, document()->defaultView(), 1000.0 * document()->loader()->timing()->monotonicTimeToZeroBasedDocumentTime(event.timestamp()))));
> 
> 1000.0 -> unnamed constants are sadness.  Perhaps we need a version of monotonicTimeToZeroBasedDocumentTime that returns the correct units?

Turns out we never actually wanted the number in seconds so I've renamed / modified this method to return in milliseconds.

As for the test failures they haven't reproduced locally for me (either the mac or cr-linux ones), is there any way I can get more information about the failures on the bots or is it possible it's just a flake?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.