[Webkit-unassigned] [Bug 103006] [EFL][WK2] Missing the routine to check the validation for workqueue
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Nov 22 04:12:28 PST 2012
https://bugs.webkit.org/show_bug.cgi?id=103006
Mikhail Pozdnyakov <mikhail.pozdnyakov at intel.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |mikhail.pozdnyakov at intel.co
| |m
--- Comment #20 from Mikhail Pozdnyakov <mikhail.pozdnyakov at intel.com> 2012-11-22 04:14:29 PST ---
(In reply to comment #19)
> (In reply to comment #18)
> > (From update of attachment 175643 [details] [details])
> > View in context: https://bugs.webkit.org/attachment.cgi?id=175643&action=review
> >
> > >> Source/WebKit2/Platform/efl/WorkQueueEfl.cpp:83
> > >> + {
> > >
> > > This { should be at the end of the previous line [whitespace/braces] [4]
> >
> > I wish we had 'bool WorkQueue::isValid() const' encapsulating all of this
>
> I think that it is better to use just "function" variable just to avoid the fail for check-webkit-style.
> WorkQueue::isValid() is redundant if it is required just to avoid the fail for check-webkit-style.
frankly I don't care about check-webkit-style at all, I just see the same code is used(copied) in several places and I have feeling that a new function would look better and it would not require creating of extra scope.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list