[Webkit-unassigned] [Bug 103006] [EFL][WK2] Missing the routine to check the validation for workqueue

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=103006





--- Comment #15 from Jongseok Yang <js45.yang at samsung.com>  2012-11-22 03:30:52 PST ---
(In reply to comment #14)
> (In reply to comment #13)
> > (In reply to comment #12)
> > > (From update of attachment 175619 [details] [details] [details])
> > > View in context: https://bugs.webkit.org/attachment.cgi?id=175619&action=review
> > > 
> > > > Source/WebKit2/Platform/efl/WorkQueueEfl.cpp:82
> > > > +        for (size_t i = 0; i < workItemQueue.size(); ++i) {
> > > 
> > > calculating size each iteration?
> > > 
> > > > Source/WebKit2/Platform/efl/WorkQueueEfl.cpp:83
> > > > +            Function<void()> function = workItemQueue[i];
> > > 
> > > Sorry if I missed something, but is it mandatory to have 'function' variable here? Could it be just 'workItemQueue[i]()' after m_isValid check?
> > 
> > It is to meet the script "check-webkit-style". 
> > I got the below result from the script when removing this line.
> > 
> > Source/WebKit2/Platform/efl/WorkQueueEfl.cpp:83:  Line contains only semicolon. If this should be an empty statement, use { } instead.  [whitespace/semicolon] [5]
> 
> That would be a bug in the style script then? because the line does NOT contain only semicolon. The style script is there to help, don't change a perfectly good code to work around a style script bug.
> Mikhail is right that we try to avoid useless temporary variables in WebKit.

Ok, it is not important issue to me. I'll fix that.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.