[Webkit-unassigned] [Bug 102817] Reset the slider thumb location before every layout of the slider container

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Nov 21 10:14:03 PST 2012


https://bugs.webkit.org/show_bug.cgi?id=102817





--- Comment #9 from Tony Chang <tony at chromium.org>  2012-11-21 10:16:04 PST ---
(In reply to comment #6)
> The initial position of the thumb slider is set by the parent container in RenderBlock::layoutBlockChild() and it depends on the padding, border and margin. I don't know if the thumb can be affected by those, because after the layoutBlockChild() the thumb position is always 0. In case of being greater than 0 I guess it makes sense to add the offset, but I guess we should also use the current thumb position when the container is not laid out.

If there was a padding/border/margin on the thumb, after bug 102352 lands, we're no longer going to be applying them on a relayout since we will reset the location to 0, 0 then not call layout on the thumb.

I would probably call thumbLocation.setX directly on the new position since it's less code, but it doesn't really matter.  Conceptually, I don't think it makes sense for web authors to be able to use CSS to control the position of the thumb.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list