[Webkit-unassigned] [Bug 102853] [EFL][WK2] Add ewk_application_cache_manager APIs

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=102853





--- Comment #2 from Jinwoo Song <jinwoo7.song at samsung.com>  2012-11-21 05:14:25 PST ---
(From update of attachment 175316)
View in context: https://bugs.webkit.org/attachment.cgi?id=175316&action=review

> Source/WebKit2/UIProcess/API/efl/ewk_application_cache_manager.cpp:47
> +    WKApplicationCacheManagerGetApplicationCacheOrigins(toAPI(m_applicationCacheManager.get()), context, callback);

You may use getApplicationCacheOrigins(PassRefPtr<ArrayCallback>) instead of WK APIs.

> Source/WebKit2/UIProcess/API/efl/ewk_application_cache_manager.cpp:68
> +struct Ewk_Application_Cache_Origins_Async_Get_Context {

I prefer to follow the WebKit coding style except in the public header files.

> Source/WebKit2/UIProcess/API/efl/ewk_application_cache_manager.cpp:84
> +    OwnPtr<Ewk_Error> ewkError = Ewk_Error::create(wkError);

s/Ewk_Error/EwkError

> Source/WebKit2/UIProcess/API/efl/ewk_application_cache_manager_private.h:43
> +        return adoptPtr(new Ewk_Application_Cache_Manager(context->applicationCacheManagerProxy()));

s/Ewk_Application_Cache_Manager/EwkApplicationCacheManager

> Source/WebKit2/UIProcess/API/efl/ewk_context.cpp:138
> +    return m_applicationCacheManager.get();

Inline function would be better.

> Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_application_cache_manager.cpp:29
> +#include "UnitTestUtils/EWK2UnitTestEnvironment.h"

unneeded include. Already included in EWK2UnitTestBase.h.

> Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_application_cache_manager.cpp:32
> +#include <EWebKit2.h>

ditto.

> Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_application_cache_manager.cpp:33
> +#include <Ecore.h>

ditto.

> Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_context.cpp:53
> +    ASSERT_EQ(applicationCacheManager, ewk_context_application_cache_manager_get(context));

This comparison seems to be meaningless.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.