[Webkit-unassigned] [Bug 101573] [V8] Add context checks to WorldContextHandle and V8DOMWindowShell

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Nov 21 03:12:49 PST 2012


https://bugs.webkit.org/show_bug.cgi?id=101573





--- Comment #11 from Dan Carney <dcarney at google.com>  2012-11-21 03:14:49 PST ---
(In reply to comment #10)
> (From update of attachment 172976 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=172976&action=review
> 
> >> Source/WebCore/bindings/v8/V8DOMWindowShell.cpp:471
> >> +    V8DOMWrapper::setJSWrapperForDOMObject(PassRefPtr<DOMWindow>(window), windowWrapper);
> > 
> > The explicit call to PassRefPtr<DOMWindow> shouldn't be necessary here.
> 
> Looks like this comment still applies to the final patch.

Yeah, I had to rebase that patch by hand and didn't see it.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list