[Webkit-unassigned] [Bug 102687] [EFL] GLX detection is broken.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=102687





--- Comment #12 from Kalyan <kalyan.kondapally at intel.com>  2012-11-20 18:30:04 PST ---
(In reply to comment #10)
> (In reply to comment #8)
> > (In reply to comment #5)
> > > > Doesn't this boil down to just detecting whether mesa is present? I thought we already did that with FIND_PACKAGE(OpenGL).
> > >
> > > This assumption would be wrong on some platforms i.e wayland.
> > 
> > (In reply to comment #6)
> > > > That's true, you could use FIND_PACKAGE(OpenGL) + check if OPENGL_XMESA_FOUND is set.
> > >
> > > I was hoping we could do this. But the problem seems to be as follows:
> > >
> > > 1)In FindOpenGL.cmake OPENGL_XMESA_FOUND is set to True if OPENGL_xmesa_INCLUDE_DIR is True
> > >
> > >     FIND_PATH(OPENGL_xmesa_INCLUDE_DIR GL/xmesa.h
> > >       /usr/share/doc/NVIDIA_GLX-1.0/include
> > >       /usr/openwin/share/include
> > >       /opt/graphics/OpenGL/include /usr/X11R6/include
> > >     )
> > >
> > > Here GL/xmesa.h  seems to be the problem. The "XMesa" interface is deprecated and GL/xmesa*.h files are  no longer considered public.
> > 
> > Could you elaborate on what the right solution that contemplated Wayland and didn't look for xmesa would be (ie. what libraries and headers would it look for)? As good citizens, it'd be nice to fix this upstream in CMake if possible.
> 
> Wayland Example: https://projects.kde.org/projects/kde/kde-workspace/repository/revisions/097771054ec91728efb08b883ae88e697df3a5c0/entry/cmake/modules/FindWayland.cmake
> 
> We should look for GL/glx.h instead of GL/xmesa.h. I was bit pessimistic here thinking about the cases where we could have bogus Glx.h file. i.e. Header present without any proper support for the interface, or completely wrong contents with the name etc. So I ended up with this sol, trying to compile some basic code.

Something to add: Wayland, doesn't support GLX interface. It rather uses Mesa EGL/EGL-X11 interface.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.