[Webkit-unassigned] [Bug 88700] Fix RenderLayerCompositor::recursiveRepaintLayerRect to respect transform

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Nov 20 16:13:11 PST 2012


https://bugs.webkit.org/show_bug.cgi?id=88700





--- Comment #6 from Tien-Ren Chen <trchen at chromium.org>  2012-11-20 16:15:10 PST ---
(In reply to comment #5)
> I would love to r+ this patch, but it's not clear what tests we would look at to confirm it was doing what was expected.
> 
> Can you please update the ChangeLog with the relevant tests we should use for this change?

Test is one issue... Another issue is the algorithmic complexity. The original code applies layer offset incrementally. It takes O(1) to enter a sub-tree. My patch re-runs the transformation chain when arriving every node, taking O(H) to enter a sub-tree at depth H. This makes tree traversal worse than O(H^2)

I'd like to make this patch to do incremental transformation, but it needs to be very careful about fixed position elements. Hopefully we can make use some of the existing code. (RenderGeometryMap looks like what we need)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list