[Webkit-unassigned] [Bug 102687] [EFL] GLX detection is broken.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=102687





--- Comment #9 from Raphael Kubo da Costa (rakuco) <rakuco at webkit.org>  2012-11-20 13:18:27 PST ---
(From update of attachment 175240)
View in context: https://bugs.webkit.org/attachment.cgi?id=175240&action=review

I need your input to my comment #8 to properly comment on your new Find-file, but a few things should be improved regardless of that:
 o It needs some documentation at the top like the other Find-files.
 o We use a 4-space indentation style instead of a 2-space one.
 o The `X11_FOUND' check implicitly assumes FindX11.cmake was already called before, which is not always the case. Since you do not include X11 headers or link against any X11 library in your CHECK_C_SOURCE_COMPILES_CALL(), it might be worth simply not checking for `X11_FOUND' at all.
 o "YES" (a string) is different from YES (a boolean). Either way, we normally use FindPackageHandleStandardArguments() to set that, since it also handles other Find-module arguments such as QUIET and the like.

> Source/cmake/OptionsEfl.cmake:161
> +  FIND_PACKAGE(OpenGLX)
> +
> +  IF (OPENGLX_FOUND)
> +    ADD_DEFINITIONS(-DHAVE_GLX)
> +  ENDIF()

Do the tiled backing store and WebGL still work if the GLX is not found?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.