[Webkit-unassigned] [Bug 96637] Remove V8DOMWindowShell::getEntered

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=96637





--- Comment #51 from Dan Carney <dcarney at google.com>  2012-11-20 12:33:06 PST ---
(In reply to comment #48)
> (From update of attachment 175227 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=175227&action=review
> 
> Very nice.
> 
> > Source/WebCore/bindings/v8/DOMWrapperWorld.h:58
> > +
> 
> By the way, is there a reason we have:
> 
> class DOMWrapperWorld : public WTF::RefCountedBase
> 
> The normal pattern is
> 
> class DOMWrapperWorld : public RefCounted<DOMWrapperWorld>
> 
> Sorry if I asked you that before and forgot.


I think there was an edge case when I started all this refactored where the main world could be deleted or something, and this was the only way to intercept the destructor. I should have added a FIXME when I added it. Anyway, it can be removed now. I'll submit a fix tomorrow.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.