[Webkit-unassigned] [Bug 102827] [CMake] Optimize binary size by removing dead sections on unix/gcc

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=102827





--- Comment #2 from Patrick R. Gansterer <paroga at paroga.com>  2012-11-20 12:13:37 PST ---
(From update of attachment 175257)
View in context: https://bugs.webkit.org/attachment.cgi?id=175257&action=review

Only a style comment, since I don't use it on Linux.

> Source/cmake/OptionsCommon.cmake:39
> +    SET(CMAKE_C_FLAGS "-ffunction-sections -fdata-sections ${CMAKE_C_FLAGS}")
> +    SET(CMAKE_CXX_FLAGS "-ffunction-sections -fdata-sections ${CMAKE_CXX_FLAGS}")

Usually this is written as SET(VAR "${VAR} additonalStuff")

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.