[Webkit-unassigned] [Bug 101346] No condition present to check if Compressed Texture S3TC extension support exists

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Nov 20 12:09:49 PST 2012


Kenneth Russell <kbr at google.com> changed:

           What    |Removed                     |Added
 Attachment #175248|review?                     |review-
               Flag|                            |

--- Comment #18 from Kenneth Russell <kbr at google.com>  2012-11-20 12:11:48 PST ---
(From update of attachment 175248)
View in context: https://bugs.webkit.org/attachment.cgi?id=175248&action=review

Looks fair overall but needs a little more work.

> Source/WebCore/html/canvas/WebGLRenderingContext.cpp:2382
> +        && m_context->getExtensions()->supports("GL_EXT_texture_compression_s3tc")) {

Use WebGLCompressedTextureS3TC::supported(WebGLRenderingContext*) instead to keep the checks here and WebGLRenderingContext::getSupportedExtensions symmetric.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list