[Webkit-unassigned] [Bug 102687] [EFL] GLX detection is broken.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Nov 20 02:12:33 PST 2012
https://bugs.webkit.org/show_bug.cgi?id=102687
--- Comment #3 from Raphael Kubo da Costa (rakuco) <rakuco at webkit.org> 2012-11-20 02:14:31 PST ---
(From update of attachment 175076)
View in context: https://bugs.webkit.org/attachment.cgi?id=175076&action=review
> Source/cmake/OptionsEfl.cmake:190
> +include(CheckCSourceCompiles)
> +include(CheckCXXSourceCompiles)
Coding style: our CMake calls are all uppercased.
> Source/cmake/OptionsEfl.cmake:200
> +CHECK_C_SOURCE_COMPILES(
> +"
> +#include <GL/glx.h>
> +int main()
> +{
> + GLXFBConfig c;
> + return 0;
> +}
> +"
> +GLXCOMPILATIONPASSED)
Doesn't this boil down to just detecting whether mesa is present? I thought we already did that with FIND_PACKAGE(OpenGL).
> Source/cmake/OptionsEfl.cmake:203
> + SET(HAVE_GLX 1)
This does not seem to be used anywhere.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list