[Webkit-unassigned] [Bug 79441] IPP optimization for functions vsma, vsmul, vadd, vmul and vmaxmgv

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=79441


Brent Fulgham <bfulgham at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #131495|review?                     |review+, commit-queue-
               Flag|                            |




--- Comment #18 from Brent Fulgham <bfulgham at webkit.org>  2012-11-19 22:47:04 PST ---
(From update of attachment 131495)
View in context: https://bugs.webkit.org/attachment.cgi?id=131495&action=review

Seems like all requested changes have been made, and look reasonable.  I found a tiny typo, but that can be fixed when this is landed.

> Source/WebCore/platform/audio/VectorMath.cpp:248
> +    if ((sourceStride1 ==1) && (sourceStride2 == 1) && (destStride == 1)) {

Nit: We need a space between the equals and the 1 here. ("==1" should be "== 1").

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.