[Webkit-unassigned] [Bug 102764] Use m_webView->size() for viewport update

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Nov 19 21:38:18 PST 2012


https://bugs.webkit.org/show_bug.cgi?id=102764





--- Comment #4 from Tien-Ren Chen <trchen at chromium.org>  2012-11-19 21:40:16 PST ---
(In reply to comment #3)
> (From update of attachment 175130 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=175130&action=review
> 
> I think the general concept here is good, but I think there is relatively weak evidence that this won't have unexpected changes in behavior.
> 
> > Source/WebKit/chromium/ChangeLog:12
> > +        rendering purpose.
> 
> While the intent of this change seems good, it seems scary to apply such a modification without at least identifying some test cases that cover this behavior. From the sound of the bug, it should be possible to construct a test case illustrating the case of a pending resize that should not be used for the current rendering.

Makes sense. The real life bug I have is this one: https://code.google.com/p/chromium/issues/detail?id=160619
That windowRect will be one frame behind when rotating an Android device.

I think I can probably do a WebFrameTest for that. I'll try tomorrow.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list