[Webkit-unassigned] [Bug 102689] [WinCairo] Crash when requesting favicon.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=102689


Brent Fulgham <bfulgham at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #174980|review?                     |review-
               Flag|                            |




--- Comment #2 from Brent Fulgham <bfulgham at webkit.org>  2012-11-19 17:38:50 PST ---
(From update of attachment 174980)
View in context: https://bugs.webkit.org/attachment.cgi?id=174980&action=review

This is a great fix, but I think it is generally clearer to do an early return. R- to make that small change.

Also, it would be nice if these Davison bugs could be covered by some kind of test.

> Source/WebCore/ChangeLog:5
> +

Is there any way to test this in our current testing infrastructure

> Source/WebCore/platform/graphics/win/ImageCairoWin.cpp:98
> +        if (frameAtIndex(i)) {

I think this might be better as an early return.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.