https://bugs.webkit.org/show_bug.cgi?id=102531
Yael <yael at webkit.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #174713|0 |1
is obsolete| |
Attachment #174713|commit-queue? |
Flag| |
Attachment #175032| |commit-queue+
Flag| |
--- Comment #3 from Yael <yael at webkit.org> 2012-11-19 13:11:49 PST ---
Created an attachment (id=175032)
--> (https://bugs.webkit.org/attachment.cgi?id=175032&action=review)
Patch
(In reply to comment #2)
> (From update of attachment 174713 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=174713&action=review
>
> > Source/WebKit2/UIProcess/efl/WebInspectorProxyEfl.cpp:93
> > + if (!m_inspectorWindow)
>
> I would add comment here // Gracefully fall back to software if evas_gl engine is not available.
Thank you for the review, I added the comment. I am not adding a warning as was done for the view, since Evas already gives a warning.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.