[Webkit-unassigned] [Bug 102647] [CMake] Add an option to build AllInOne files

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=102647


Alexis Menard (darktears) <alexis at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |alexis at webkit.org




--- Comment #5 from Alexis Menard (darktears) <alexis at webkit.org>  2012-11-19 10:21:53 PST ---
(In reply to comment #4)
> Looking at the logs for these AllInOne.cpp files they were generally created to address build problems on Win32.
> 
> I didn't get what you meant by "macro bloat" in this case.
> 
> The -DENABLE_ALLINONE approach doesn't look very clean to me -- IMHO we should either always use these files or not use them (the Mac approach seems to be to always use AllInOne files on Win32 in release mode and the regular files in all other configurations).

I tend to agree with Raphael. From what I recall AllinOne files were added to workaround the fact that the windows 32 bits linker couldn't handle linking WebKit. Compare it to linking a debug version of WebKit on a 32 bits machine with 2GB of RAM. A point of time the link will fail because the kernel will kill ld. I think they were added back then to actually make the linking possible. I don't think they bring any benefits maybe by side effects. I'm not that good with Windows in depth bit but that's what I remember. Now is that even valid for modern MSVC, even on 32 bits? Good question that would need testing.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.