[Webkit-unassigned] [Bug 102647] [CMake] Add an option to build AllInOne files

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=102647





--- Comment #3 from Patrick R. Gansterer <paroga at paroga.com>  2012-11-19 00:58:02 PST ---
(From update of attachment 174895)
View in context: https://bugs.webkit.org/attachment.cgi?id=174895&action=review

> Source/WebCore/ChangeLog:10
> +        when ENABLE_ALLINONE cmake option is set.

AFAIK there is no ENABLE(ALLINONE) in the C++ files, so i'd suggest a name without ENABLE_ prefix (BTW: even it is a C++ define, then it should be USE() and not ENABLE())
Did you thought about reading the *AllInOne-Files, and let CMake remove the include files from its source list? this would avoid maintainig the list twice. I don't know if it is practicable, only an idea.

> Source/WebCore/ChangeLog:12
> +        No new tests (OOPS!).

no reason to inlcude this line

> Source/WebCore/CMakeLists.txt:2246
> +  LIST(APPEND WebCore_SOURCES

4 spaces indent

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.