[Webkit-unassigned] [Bug 101291] [EFL] Refactor GraphicsContext3DEFL

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=101291





--- Comment #39 from Kalyan <kalyan.kondapally at intel.com>  2012-11-17 21:50:21 PST ---
(In reply to comment #32)
> (From update of attachment 174621 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=174621&action=review
> 
> > Source/WebCore/platform/graphics/efl/GLContext.h:1
> > +/*
> 
> Will you move these to say Source/WebCore/platform/graphics/opengl/GLContext.h ?

done 

> 
> > Source/WebCore/platform/graphics/surfaces/glx/GLXSurface.cpp:100
> > +{
> > +    if (m_drawable) {
> > +        if (m_restoreNeeded) {
> > +            GLint oldFBO;
> > +            glGetIntegerv(GL_FRAMEBUFFER_BINDING, &oldFBO);
> > +            glBindFramebuffer(GL_FRAMEBUFFER, 0);
> > +            glXSwapBuffers(sharedDisplay(), m_drawable);
> > +            glBindFramebuffer(GL_FRAMEBUFFER, oldFBO);
> > +        } else
> > +            glXSwapBuffers(sharedDisplay(), m_drawable);
> > +    }
> > +}
> 
> This we write as 
> 
> if (!m_drawable)
>     return;
> 
 fixed 

> 
> > Source/WebCore/platform/graphics/surfaces/glx/GLXSurface.cpp:179
> > +    return pBufferConfig();
> 
> pBufferConfiguration then, or just rename this to config() then. We need to be consistent

fixed

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.