[Webkit-unassigned] [Bug 100061] [chromium] Device scale factor should be no-op when applyDeviceScaleFactorInCompositor == 0

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Nov 17 10:04:23 PST 2012


https://bugs.webkit.org/show_bug.cgi?id=100061





--- Comment #20 from Adam Barth <abarth at webkit.org>  2012-11-17 10:06:16 PST ---
(From update of attachment 174796)
View in context: https://bugs.webkit.org/attachment.cgi?id=174796&action=review

> Source/WebKit/chromium/src/WebViewImpl.cpp:4349
> +bool WebViewImpl::shouldApplyDeviceScaleFactorInCompositor() const
> +{
> +    return m_webSettings->applyDeviceScaleFactorInCompositor();
> +}

I don't really understand the point of this function.  Why don't callers just get the information from the settings themselves?  We don't want to create these sorts of accessors for every setting...

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list