[Webkit-unassigned] [Bug 102352] Avoid a second layout of flex items in layoutAndPlaceChildren()

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=102352





--- Comment #8 from Carlos Garcia Campos <cgarcia at igalia.com>  2012-11-17 02:06:03 PST ---
(In reply to comment #7)
> (From update of attachment 174641 [details])
> Tests are still failing.  We need to debug the cause of the failure.  Applying the change less often isn't going to make the bug go away.

Sure, I debugged the auto-margins case, and the problem was that the logical height is updated during the layout and it resets the margins, so when not laying out the margins already had the right value that is used to calculate the margin again, which ended up resetting to 0. So, just calling child->updateLogicalHeight() when avoiding the layout of the child, fixed the test, but I was not sure that was the right approach and that didn't fix the other tests. So, my guess is that when avoiding the layout, we should still do other things that happen during the layout even if they don't affect the size. I think the problem with the other failures has to do with the position, for some reason, when laying out multiple times the child is moved several times, but the final position is the same than when avoiding the layout. Next week I'll continue debugging the test failures.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.