[Webkit-unassigned] [Bug 102422] Add setChecked API in WebInputElement

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=102422





--- Comment #5 from Raman Kumar <ramankk at chromium.org>  2012-11-16 14:39:26 PST ---
(From update of attachment 174742)
View in context: https://bugs.webkit.org/attachment.cgi?id=174742&action=review

>> Source/WebKit/chromium/ChangeLog:8
>> +        Additional information of the change such as approach, rationale. Please add per-function descriptions below (OOPS!).
> 
> Please fill out this part of the ChangeLog.

Done. Sorry for that, this is my first CL in webkit, still figuring out the process.

>> Source/WebKit/chromium/public/WebInputElement.h:77
>> +        WEBKIT_EXPORT void setChecked(bool, bool sendChangeEvent = false);
> 
> Can we use an enum for the second parameter rather than a raw boolean?  It looks like HTMLInputElement already uses an enum.

This change is consistent with setValue(), HTMLInputElement's setValue also uses same enum. I don't exactly understand why bool was preferred here earlier, assuming there is a reason, I am trying to be consistent.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.