[Webkit-unassigned] [Bug 101910] Web Inspector: line number of script should be search-able in Timeline Panel

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=101910





--- Comment #22 from pdeng6 <pan.deng at intel.com>  2012-11-16 06:10:59 PST ---
(In reply to comment #20)
> (From update of attachment 174369 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=174369&action=review
> 
> >>> Source/WebCore/inspector/front-end/TimelinePresentationModel.js:888
> >>> +                    contentHelper._appendTextRow(WebInspector.UIString("Details"), this.detailsNode().childNodes[1].textContent);
> >> 
> >> So this is a third time I am suggesting to call appendElementRow here :) Is there a reason why this is bad?
> > 
> > I've tested it, appendElementRow will move the node from TimelineRecordListRow to contentHelper, did I mis-use this function? or a deep cloned node needed?
> 
> Yeah, you probably want to clone it and you don't want ( and ) to be a part of the details node, right?
thanks. cloned it.
> 
> >>> Source/WebCore/inspector/front-end/TimelinePresentationModel.js:1006
> >>> +        if (!details)
> >> 
> >> You don't need this check now.
> > 
> > without this, this method may return undefined, and the testing for (typeof this._details === "undefined") will not work.
> > I would like to change as < return details ? details : null >, how do you think of it?
> 
> Just put var details = null; above?
I think "var details = null" won't solve, "details" may be set undefined during switch..

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.