[Webkit-unassigned] [Bug 102339] Provide page/window coordinates to plugin's local coordinates translation in WebPluginContainer.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=102339





--- Comment #15 from lazyboy at chromium.org  2012-11-15 17:50:03 PST ---
(From update of attachment 174541)
View in context: https://bugs.webkit.org/attachment.cgi?id=174541&action=review

Sending replies.
Thanks for the review.

>> Source/WebKit/chromium/tests/FrameTestHelpers.h:46
>> +};
> 
> What's the point of exposing the class?

Comment below.

>> Source/WebKit/chromium/tests/WebPluginContainerTest.cpp:71
>> +class TestPluginWebFrameClient : public FrameTestHelpers::TestWebFrameClient {
> 
> It seesms like this class could just as easily inherit from WebFrameClient directly.

Yes it easily could.
All tests using same base Test* class would have the benefit that we share mocking/testing properties as much, so down the road if anyone adds useful stub to TestWebFrameClient, we get that for free here.
Unfortunately this is not a win-win situation as I think of it more now, it also makes TestWebFrameClient more constrained, it cannot break certain plugin functionality this test expects (which is empty at this moment).
I can remove this and make it direct subclass of WebFrameClient if you like.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.