[Webkit-unassigned] [Bug 102339] Provide page/window coordinates to plugin's local coordinates translation in WebPluginContainer.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=102339


Adam Barth <abarth at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #174541|review?                     |review+
               Flag|                            |




--- Comment #14 from Adam Barth <abarth at webkit.org>  2012-11-15 17:34:38 PST ---
(From update of attachment 174541)
View in context: https://bugs.webkit.org/attachment.cgi?id=174541&action=review

Thanks.  One (minor) question below.

> Source/WebKit/chromium/tests/FrameTestHelpers.h:46
> +class TestWebFrameClient : public WebFrameClient {
> +};

What's the point of exposing the class?

> Source/WebKit/chromium/tests/WebPluginContainerTest.cpp:71
> +class TestPluginWebFrameClient : public FrameTestHelpers::TestWebFrameClient {

It seesms like this class could just as easily inherit from WebFrameClient directly.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.