[Webkit-unassigned] [Bug 102323] Add Settings to disable custom scrollbars on main frame

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=102323


Adam Barth <abarth at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #174537|review?                     |review+, commit-queue-
               Flag|                            |




--- Comment #7 from Adam Barth <abarth at webkit.org>  2012-11-15 17:26:50 PST ---
(From update of attachment 174537)
View in context: https://bugs.webkit.org/attachment.cgi?id=174537&action=review

> Source/WebCore/page/FrameView.cpp:513
> +        if (!settings->allowCustomScrollbarInMainFrame() && m_frame->page() && m_frame->page()->mainFrame() == m_frame)

The test for m_frame->page() isn't actually needed because the only way |settings| can be non-0 is if m_frame->page() is non-0, but it's fine to leave the test here as a security blanket.

> Source/WebCore/page/Settings.h:850
> +        bool m_allowCustomScrollbarInMainFrame : 1;

You should add this to Settings.in now that we have fancy-pants auto generation of this file.  :)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.