[Webkit-unassigned] [Bug 102339] Provide page/window coordinates to plugin's local coordinates translation in WebPluginContainer.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=102339





--- Comment #10 from lazyboy at chromium.org  2012-11-15 15:02:29 PST ---
(From update of attachment 174501)
View in context: https://bugs.webkit.org/attachment.cgi?id=174501&action=review

>> Source/WebKit/chromium/src/WebFrameImpl.cpp:307
>> +WebPluginContainerImpl* WebFrameImpl::pluginContainerFromNode(const WebNode& node)
> 
> Should this be a function on WebNode?

Moved the function to WebElement (non-static). Calling it pluginContainerFromElement(), "FromElement" part seems extraneous, but taking it away also creates confusion, do you have any suggestion?

>> Source/WebKit/chromium/tests/WebPluginContainerTest.cpp:74
>> +        if (params.mimeType == WebKit::FakeWebPlugin::mimeType())
> 
> No need for "WebKit::".  We're already in the WebKit namespace.

Done.

>> Source/WebKit/chromium/tests/WebPluginContainerTest.cpp:84
>> +}
> 
> Why is this static?  We should just create one on the stack for each test.

Copy paste effect from WebViewTest.
Fixed.

>> Source/WebKit/chromium/tests/WebPluginContainerTest.cpp:89
>> +    return WebFrameImpl::pluginContainerFromNode(element);
> 
> Yeah, moving pluginContainerFromNode to WebElement might be the best thing.

Moved.

>> Source/WebKit/chromium/tests/WebPluginContainerTest.cpp:97
>> +    static_cast<WebViewImpl*>(webView)->settings()->setPluginsEnabled(true);
> 
> Why WebViewImpl?  You should be able to do all this this through the API.

Done.

>> Source/WebKit/chromium/tests/WebPluginContainerTest.cpp:102
>> +    WebPluginContainerImpl* pluginContainerOne = getWebPluginContainer(webView, WebString::fromUTF8("translated-plugin"));
> 
> Why WebPluginContainerImpl?  You should be able to do all of this though the API.

Done.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.