[Webkit-unassigned] [Bug 102403] [chromium] Copy linux theme related files to default

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=102403


Tony Chang <tony at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #174477|review?                     |review+
               Flag|                            |




--- Comment #4 from Tony Chang <tony at chromium.org>  2012-11-15 10:45:32 PST ---
(From update of attachment 174477)
View in context: https://bugs.webkit.org/attachment.cgi?id=174477&action=review

> Source/Platform/ChangeLog:6
> +        Reviewed by Tony Change.

You should leave this as "NOBODY (OOPS!)" until you get an r+.  webkit-patch or the cq will fill in the reviewer for you.

> Source/WebCore/rendering/RenderThemeChromiumDefault.h:92
> +    static void setSelectionColors(unsigned activeBackgroundColor,
> +                                   unsigned activeForegroundColor,
> +                                   unsigned inactiveBackgroundColor,
> +                                   unsigned inactiveForegroundColor);

You can either unwrap this into a single line or just indent 4 spaces from the previous line.  I would probably just leave it on a single line.

> Source/WebKit/chromium/src/WebViewImpl.cpp:3570
> +    RenderThemeChromiumDefault::setSelectionColors(activeBackgroundColor,
> +                                                   activeForegroundColor,
> +                                                   inactiveBackgroundColor,
> +                                                   inactiveForegroundColor);

Same as above, either unwrap (seems easier) or indent 4 spaces from the previous line.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.