[Webkit-unassigned] [Bug 102339] Provide page/window coordinates to plugin's local coordinates translation in WebPluginContainer.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=102339


Adam Barth <abarth at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #174357|review?                     |review-
               Flag|                            |




--- Comment #5 from Adam Barth <abarth at webkit.org>  2012-11-15 10:28:11 PST ---
(From update of attachment 174357)
View in context: https://bugs.webkit.org/attachment.cgi?id=174357&action=review

> Source/WebKit/chromium/ChangeLog:8
> +        Additional information of the change such as approach, rationale. Please add per-function descriptions below (OOPS!).

Please fill out this part of the ChangeLog.

> Source/WebKit/chromium/tests/FrameTestHelpers.cpp:60
> +    virtual WebPlugin* createPlugin(WebFrame* frame, const WebPluginParams& params) OVERRIDE

We shouldn't need to add this to every TestWebFrameClient.  The tests in WebPluginContainerTest.cpp should create a new subclass of TestWebFrameClient that adds this override.

> Source/WebKit/chromium/tests/WebPluginContainerTest.cpp:66
> +WebPluginContainerImpl* getWebPluginContainer(WebView* webView, const WebString& id)

This function dives too much into WebCore.  We should be able to write these tests in terms of the WebKit API, not in terms of WebCore implementation details.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.