[Webkit-unassigned] [Bug 102403] [chromium] Copy linux theme related files to default

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=102403





--- Comment #2 from Scott Violet <sky at chromium.org>  2012-11-15 10:15:11 PST ---
There are a 2 style issues in the patch. One in RenderThemeChromiumDefault:

    static void setSelectionColors(unsigned activeBackgroundColor,
                                   unsigned activeForegroundColor,
                                   unsigned inactiveBackgroundColor,
                                   unsigned inactiveForegroundColor);

The style guide doesn't mention wrapping. Should I convert to a single line, eg:

    static void setSelectionColors(unsigned activeBackgroundColor, unsigned activeForegroundColor, unsigned inactiveBackgroundColor, unsigned inactiveForegroundColor);


And similarly a call site:

    RenderThemeChromiumDefault::setSelectionColors(activeBackgroundColor,
                                                   activeForegroundColor,
                                                   inactiveBackgroundColor,
                                                   inactiveForegroundColor);

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.