[Webkit-unassigned] [Bug 102077] Favicons are flipped in vertical direction in WinCairo builds.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=102077


Brent Fulgham <bfulgham at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #173882|review?                     |review-
               Flag|                            |




--- Comment #2 from Brent Fulgham <bfulgham at webkit.org>  2012-11-15 09:07:39 PST ---
(From update of attachment 173882)
View in context: https://bugs.webkit.org/attachment.cgi?id=173882&action=review

The code changes seem reasonable, but do you have a test case that can be used to show that it currently doesn't work, and that this change fixes it?

> Source/WebCore/platform/graphics/win/ImageCairoWin.cpp:70
> +    unsigned char *bmpdata = (unsigned char*)bmpInfo.bmBits + bmpInfo.bmWidthBytes*(bmpInfo.bmHeight-1);

This should be declared "unsigned char*"

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.