[Webkit-unassigned] [Bug 94987] Add systemTime to DOM events

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Nov 15 09:03:15 PST 2012


https://bugs.webkit.org/show_bug.cgi?id=94987





--- Comment #79 from Robert Flack <flackr at chromium.org>  2012-11-15 09:05:01 PST ---
(In reply to comment #78)
> Attachment 174436 [details] did not pass style-queue:
> 
> Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/plat..." exit_code: 1
> Source/WebCore/dom/WheelEvent.h:80:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
> Source/WebCore/dom/WheelEvent.cpp:44:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
> Source/WebCore/dom/WheelEvent.cpp:51:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
> Source/WebCore/dom/UIEventWithKeyState.h:48:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
> Source/WebCore/dom/MouseRelatedEvent.h:70:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
> Source/WebCore/page/EventHandler.cpp:3867:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
> Source/WebCore/page/EventHandler.cpp:3868:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
> Source/WebCore/dom/MouseEvent.cpp:63:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
> Source/WebCore/dom/MouseEvent.cpp:64:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
> Source/WebCore/dom/MouseEvent.cpp:197:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
> Source/WebCore/dom/MouseEvent.h:95:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
> Source/WebCore/dom/KeyboardEvent.cpp:103:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
> Source/WebCore/dom/MouseRelatedEvent.cpp:60:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
> Total errors found: 13 in 49 files
> 
> 
> If any of these errors are false positives, please file a bug against check-webkit-style.

These are pre-existing indentation styles which are consistent with the rest of the files. Should I fix them, and if so just the affected methods or the rest of the file too?

I don't know why the mac bot hasn't run on the latest patch but I've fixed the compile error on a local mac webkit build.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list