[Webkit-unassigned] [Bug 101727] [GTK] Isolate the GTK/Gail/Pango specific code in accessibility/gtk

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=101727





--- Comment #6 from Mario Sanchez Prada <mario at webkit.org>  2012-11-15 04:05:10 PST ---
(In reply to comment #5)
> (In reply to comment #4)
> > (In reply to comment #3)
> > > I think we should just replace this code for both platforms with something platform-independent, if possible.
> > 
> > This was discussed at bug 99578 comment 4, 5 and 6. The idea is replace the gail/pango code used to implement some methods of AtkText. Mario suggested stuff like TextIterator, that it is already in use. But that task can be long, so first step is isolate that code (this patch) while working on the final and platform-independent solution. In summary: this isolation is a temporary solution.
> 
> Hrm. Do you mean that there will be many patches and the work will be incomplete during that time?

As for WebKitGTK the work won't ever be incomplete (it will for other ports, though), since it will keep working as it used to do so far. These conditional compilation units were added just to ease the work of other ports (EFL) should they want to reuse the non-GTK dependant ATK code (which is 99% already).

However, I'd expect that over time (probably while implementing those notimplemented() bits in the #if !PLATFORM(GTK) regions) most of those conditional bits (e.g. pango / gail) will be implemented in a more generic way so they could be shared by all the ports. Which I think is what you suggested in your first comment.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.