[Webkit-unassigned] [Bug 102054] [EFL][WK2] Add APIs to get/set whether scripts can open new windows.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=102054





--- Comment #6 from Yuni Jeong <yhnet.jung at samsung.com>  2012-11-15 03:00:08 PST ---
(From update of attachment 174331)
View in context: https://bugs.webkit.org/attachment.cgi?id=174331&action=review

>> Source/WebKit2/UIProcess/API/efl/ewk_settings.cpp:323
>> +    EINA_SAFETY_ON_NULL_RETURN_VAL(settings, false);
> 
> I think we don't need to set if enable value is same as current value.
> 
> For example, you may add this condition.
> 
> bool currentValue = settings->preferences()->javaScriptCanOpenWindowsAutomatically();
> if (currentValue == enable)
>     return;

I agree to your idea.
But, other APIs to set enable value do not check above condition.
Above condition must be added in this function?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.