[Webkit-unassigned] [Bug 101910] Web Inspector: line number of script should be search-able in Timeline Panel
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Nov 15 01:42:44 PST 2012
https://bugs.webkit.org/show_bug.cgi?id=101910
--- Comment #16 from pdeng6 <pan.deng at intel.com> 2012-11-15 01:44:32 PST ---
(In reply to comment #14)
> (From update of attachment 174361 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=174361&action=review
>
> > Source/WebCore/inspector/front-end/TimelinePanel.js:1344
> > + toSearchText += record.detailsNode() ? (" " + record.detailsNode().textContent) : "";
>
> Nit: you don't need ternary operator when second part is noop.
> if (record.detailsNode())
> toSearchText += record.detailsNode();
>
thanks, done
> > Source/WebCore/inspector/front-end/TimelinePresentationModel.js:925
> > + this._details = this._getRecordDetails() ? this._getRecordDetails().textContent : this._getRecordDetails();
>
> This way you build record details node twice. I don't think you need this method at all btw.
agree, removed this method.
>
> > Source/WebCore/inspector/front-end/TimelinePresentationModel.js:959
> > + case WebInspector.TimelineModel.RecordType.GCEvent:
>
> Please separate formatting changes from the semantics ones. I can't track what has changed here. I wouldn't change it at this point since we'll lose blame capabilities.
see :), formats will be changed in another patch.
>
> > Source/WebCore/inspector/front-end/TimelinePresentationModel.js:1020
> > + if (typeof details !== "object")
>
> typeof details === "string"
done, thanks.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list