[Webkit-unassigned] [Bug 102028] Use correct unscaled document size when calculating scale limits

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=102028





--- Comment #6 from Tien-Ren Chen <trchen at chromium.org>  2012-11-14 19:51:39 PST ---
(In reply to comment #4)
> (From update of attachment 173781 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=173781&action=review
> 
> > Source/WebCore/page/FrameView.h:98
> >      virtual void setContentsSize(const IntSize&);
> > +    IntSize unscaledContentsSize() const;
> 
> I'm not sure I understand the relationship between these functions.  Is setContentsSize also unscaled?

Nope, setContentsSize is scaled.

I agree it is super confusing. And it doesn't really fit into current code, where contentsSize() uses push model, that RenderView pushes new contents size to the containing frame, and we use pull model to get latest unscaled contents size from RenderView. My decision is to keep it as a static helper function in WebViewImpl.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.