[Webkit-unassigned] [Bug 101883] [TexMap][Cairo] Accelerated compositing debug visuals

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=101883





--- Comment #9 from Kenneth Rohde Christiansen <kenneth at webkit.org>  2012-11-14 14:30:27 PST ---
(From update of attachment 174259)
View in context: https://bugs.webkit.org/attachment.cgi?id=174259&action=review

> Source/WebCore/platform/graphics/texmap/TextureMapperGL.cpp:357
> +    // cairo_text_extents() requires a cairo_t, so dimensions need to be guesstimated.

no way of getting hold of that?

> Source/WebCore/platform/graphics/texmap/TextureMapperGL.cpp:361
> +    cairo_surface_t* surface = cairo_image_surface_create(CAIRO_FORMAT_ARGB32, width, height);

why not use RefPtr they work for cairo_surface_t! etc

> Source/WebCore/platform/graphics/texmap/TextureMapperGL.cpp:362
> +    cairo_t* cr = cairo_create(surface);

Here you have one, a bit too late :)

> Source/WebCore/platform/graphics/texmap/TextureMapperGL.cpp:363
> +    cairo_surface_destroy(surface);

Is this safe here? cr stays valid?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.