[Webkit-unassigned] [Bug 101883] [TexMap][Cairo] Accelerated compositing debug visuals

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=101883


Martin Robinson <mrobinson at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #173539|review?                     |review+, commit-queue-
               Flag|                            |




--- Comment #5 from Martin Robinson <mrobinson at webkit.org>  2012-11-14 13:58:44 PST ---
(From update of attachment 173539)
View in context: https://bugs.webkit.org/attachment.cgi?id=173539&action=review

Looks sane to me.

>> Source/WebCore/platform/graphics/texmap/TextureMapperGL.cpp:365
>> +    cairo_set_source_rgb(cr, 1, 0, 0);
> 
> Qt has comment about blue color that it will turn red because R+B are not swapped. 
> Will it result blue or red here? If it will result in different color from specified, IMHO, it requires comment here.

You probably want to do the same thing as Qt above here.

> Source/WebCore/platform/graphics/texmap/TextureMapperGL.cpp:372
> +    cairo_move_to(cr, 2, pointSize);

Is this 2 pixels just padding?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.