[Webkit-unassigned] [Bug 87905] Can avoid a second layout of flex-items in some cases

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=87905


Tony Chang <tony at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #174091|review?                     |review-
               Flag|                            |




--- Comment #2 from Tony Chang <tony at chromium.org>  2012-11-14 11:01:48 PST ---
(From update of attachment 174091)
View in context: https://bugs.webkit.org/attachment.cgi?id=174091&action=review

> Source/WebCore/rendering/RenderFlexibleBox.cpp:1090
> +        LayoutUnit childCurrentSize = isColumnFlow() ? child->logicalHeight() : child->logicalWidth();

You want mainAxisExtentForChild().  You don't want the child's logical height since it can have an orthogonal writing mode to the flexbox.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.