[Webkit-unassigned] [Bug 101740] [Qt][ARM][MIPS]REGRESSION(r133953): It broke the build

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=101740





--- Comment #16 from Peter Gal <galpeter at inf.u-szeged.hu>  2012-11-14 06:10:08 PST ---
(In reply to comment #10)
> Created an attachment (id=173323)
 --> (https://bugs.webkit.org/attachment.cgi?id=173323&action=review) [details]
> Keep template fix
> 
> Template implementation moved from JITPropertyAccess32_64.cpp to JITPropertyAccess.cpp.

I don't really like this, because you move a JSVALUE32_64 specific code to the general JSPropertyAccess.cpp. A developer could miss it if he/she only checks the 32_64 file. (I know it's not a big reason, but then why does the 32_64.cpp file exists...)

If this is not a solid reason, then ok. go with it.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.