[Webkit-unassigned] [Bug 101910] Web Inspector: line number of script should be search-able in Timeline Panel

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Nov 14 00:18:39 PST 2012


https://bugs.webkit.org/show_bug.cgi?id=101910


Pavel Feldman <pfeldman at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #173890|review?                     |review-
               Flag|                            |




--- Comment #8 from Pavel Feldman <pfeldman at chromium.org>  2012-11-14 00:20:26 PST ---
(From update of attachment 173890)
View in context: https://bugs.webkit.org/attachment.cgi?id=173890&action=review

> Source/WebCore/inspector/front-end/TimelinePresentationModel.js:930
> +        if (details && details.hasOwnProperty('textContent'))

You should check for (details instanceof Node) and then use textContent.

But as Eugene mentioned, the fact that details() returns either string or Node is the root of the problem. I'd rename details() to detailsNode() and create a span with text in case of text content there. Then I would use detailsNode.textContent in testContentMatching and removed the similar type check from WebInspector.TimelineRecordListRow.prototype.update + would also use appendElementRow in _generatePopupContentWithImagePreview.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list