[Webkit-unassigned] [Bug 102049] Split NetworkRequest up into a request class and a loading class

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Nov 13 13:59:41 PST 2012


https://bugs.webkit.org/show_bug.cgi?id=102049





--- Comment #5 from Brady Eidson <beidson at apple.com>  2012-11-13 14:01:26 PST ---
(In reply to comment #4)
> (From update of attachment 173827 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=173827&action=review
> 
> Great idea!
> 
> > Source/WebKit2/ChangeLog:10
> > +        This patch splits it into "NetworkResourceLoadParameters" for all request-related data
> 
> Can the former keep the NetworkRequest name?

I started out keeping that name, but the naming started to fall apart as the "request" contained a "request" and it also contained datum not related directly to the request.

I also noticed that - from the perspective of WebCore in the WebProcess - this data represents a "ResourceLoader" that has already been created.

I'm definitely open to discussion and suggestions on this naming, but I'm going to land as-is since any changes are an easy substitution followup.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list